Closed da-ekchajzer closed 1 year ago
I see a lot of if foo.status == Status.NONE: in the code.
tmp = sub[sub['manufacturer'] == self.cpu_manufacturer] if len(tmp) > 0: sub = tmp.copy() if self.workloads.status != Status.NONE:
I think we should consider refactoring these with functions like foo.is_set(), foo.is_default(), etc. It will make the code easier to read.
foo.is_set()
foo.is_default()
From @samuelrince https://github.com/Boavizta/boaviztapi/pull/110#discussion_r950697116
Problem
I see a lot of if foo.status == Status.NONE: in the code.
Solution
I think we should consider refactoring these with functions like
foo.is_set()
,foo.is_default()
, etc. It will make the code easier to read.From @samuelrince https://github.com/Boavizta/boaviztapi/pull/110#discussion_r950697116