Boavizta / boaviztapi

🛠 Giving access to BOAVIZTA reference data and methodologies trough a RESTful API
GNU Affero General Public License v3.0
66 stars 23 forks source link

Cpu die size per core complete update #148

Closed da-ekchajzer closed 1 year ago

da-ekchajzer commented 1 year ago

Problem

The auto-completion process for CPU die_size_per_core was implemented as follows :

We have listed in cpu_manufacture.csv the die size per core for each CPU architecture, for each number of cores. We used data from several sources to identify the die_size_per_core.

This implementation as several problems :

This PR correct those issues.

  1. cpu_manufacture.csv contains only die_size_per_core for available data. No assumption are made to retrieve other die sizes.
  2. If core_units is given by the user, the closest die_size_per_core in terms of core_units is used min(abs(core_unit - cpu_manufacture.csv.core_units)). Otherwise, the maximizing die_size_per_core is used.
  3. We always use and never change core_units if given by the user. When evaluating the die size of a CPU we use the die_size_per_core retrieve during the completion process and the core_units given by the user or set by default.
da-ekchajzer commented 1 year ago

Thanks for the review. We do not use missing_cpu_manufacture.csv it's just a way to track which families are missing.