Boavizta / boaviztapi

🛠 Giving access to BOAVIZTA reference data and methodologies trough a RESTful API
GNU Affero General Public License v3.0
66 stars 21 forks source link

Feat(compatibility): add tool for checking Python compatibility locally #276

Closed Shillaker closed 3 months ago

Shillaker commented 4 months ago

Changes

Why?

Reminds people to check Python compatibility when making changes, and gives them a quick way to check (provided they have Docker installed).

da-ekchajzer commented 3 months ago

Thank you for the PR.

We have decided to drop python 3.8 but maintain the API for python >= 3.9. See : https://github.com/Boavizta/boaviztapi/pull/278. Could you set MINIMUM_PY_VERSION=3.8 to python 3.9 ?

What do you think about executing make test-compat-min and make test-compat-max in test CI ?

da-ekchajzer commented 3 months ago

I've added testing and compatibility testing to the release workflow. I've also set the minimum compatibility version to 3.9.

I think we can merge. I'll let you validate.

Shillaker commented 3 months ago

Awesome, LGTM!