search

Boavizta / boaviztapi

🛠 Giving access to BOAVIZTA reference data and methodologies trough a RESTful API
GNU Affero General Public License v3.0
66 stars 21 forks source link

Remove 0.491 constant value from CPU die size #279

Closed tibosmn closed 3 months ago

tibosmn commented 3 months ago

Fixes #275

In the current computation of CPU die size, we include a constant value of 0.491 cm², derived from Green Cloud Computing (Figure 31, where the precise value is 0.49157).

Given that we now utilize a die size derived from a more extensive range of CPU models than those examined in the referenced study, the addition of such a constant is unnecessary to the computation die size = die size per core * number of cores.

Consequently, I suggest setting constant_core_impact to 0 to easily handle this issue. Please advise if I should remove core_impact altogether.

tibosmn commented 3 months ago

To ease future maintainability I removed constant_core_impact and core_impact altogether.

Also updated the unit tests, sry :clown_face:

da-ekchajzer commented 3 months ago

I've fixed the conflict linked to updating unit tests in the PR : https://github.com/Boavizta/boaviztapi/pull/272.

demeringo commented 3 months ago

[!IMPORTANT]
This change may slightly update the values of embedded impacts returned by he API (e.g. https://github.com/Boavizta/cloud-scanner/issues/467)