Boavizta / boaviztapi

🛠 Giving access to BOAVIZTA reference data and methodologies trough a RESTful API
GNU Affero General Public License v3.0
66 stars 21 forks source link

Providing data for Azure virtual machines #282

Open bpetit opened 2 months ago

bpetit commented 2 months ago

Hi there,

Here is a PR aggregating data to feed the API with Microsoft Azure data for virtual machines (and supposed underlying hosts).

This should not be merged until we at least clean it up (for instance, our scripts are not PEP8 at all 😋) and improve the readme (+ that it is reviewed of course), but we wanted to allow contributors to review it in advance and give feedbacks.

I hope it is not too much noise until it is clean.

kudos @bdromard and ping to join the discussion :)

bpetit commented 2 months ago

We tried to assess how coherent the data is by comparing it to AWS instances, and are running analysis on how the different input data and hypothesis are important in the result.

So far, it seems coherent, so if anyone want to review the PR, that would be great :)

You can find results we generated for testing in results.csv and the script that generated those data in generate_impact_azure.

Let us know if we could do something more to make review easier.

Cheers

bpetit commented 2 months ago

Tried to explain a bit more the perimeter covered by the api's cloud/instance route here. I'd be happy to have your feedback on this :)

bpetit commented 2 months ago

Hi @da-ekchajzer @demeringo @samuelrince,

Data generated in result.csv seem coherent, not too far from data generated for AWS instances with the same script.

I think we could procede with a global review any time you want now.

Last thing I may do, but it could be in another PR, will be to include data for instances still missing, especially A and B series.

As said in the README, we thank GreenPixie for sponsoring this PR.

demeringo commented 1 month ago

Tried to explain a bit more the perimeter covered by the api's cloud/instance route here. I'd be happy to have your feedback on this :)

Great, particularly the diagram 👍