search

Boavizta / cloud-scanner

📡 Get Boavizta impact data for your aws cloud account usage.
GNU Affero General Public License v3.0
34 stars 8 forks source link

Return API and scanner version in the json output #265

Open demeringo opened 1 year ago

demeringo commented 1 year ago

Problem

As the underlying Boavizta API may evolve over time, it becomes difficult to compare results of cloud scanner (they may vary depending on the improvements on the API itself).

The same thing may be true for the scanner, if the calclulation method evolves for example.

Solution

The scanner should return some metadata in addition to the values/estimations provided in the json output.

Alternatives

Additional context or elements

Not sure if the API returns it's version or other metadata on a given route.

  1. Verify if info exists in a easy to consume way (or maybe implement it) on the API
  2. Add it to the output of cloud-scanner
demeringo commented 1 year ago

API version maybe should be picked up directly from the openapi spec.

demeringo commented 1 month ago

Fetch API version directly from the API once https://github.com/Boavizta/boaviztapi/pull/326 and https://github.com/Boavizta/boaviztapi/issues/299 have been released.

Implies to regenerate an API client SDK (which should be done anyway for #576).