search

Boavizta / cloud-scanner

📡 Get Boavizta impact data for your aws cloud account usage.
GNU Affero General Public License v3.0
32 stars 7 forks source link

Usage duration appear both in the inventory file and as a parameter passed to estimation command #502

Closed demeringo closed 1 month ago

demeringo commented 1 month ago

Bug description

Usage duration appear both in the inventory file and as a parameter passed to estimation command, this may be confusing and lead to conflicts when the ability to get estimate from an existing inventory is implemented. #352

To Reproduce

Expected behavior

Decide and document the behavior or remove the duplication.

JSON OUTPUT

Additional context

demeringo commented 1 month ago

In current behavior, the usage_duration_hours passed in parameter is used to perform the calulation. We removed the duration parameter that pre-existed in the inventory as it was never used.

demeringo commented 1 month ago

Should be closed by #505