search

Boavizta / environmental-footprint-data

💾 Boavizta.org Data repository
118 stars 32 forks source link

Fix manually entered data for Apple devices #80

Closed pabluk closed 1 year ago

pabluk commented 1 year ago

This PR fixes some minor issues related to https://github.com/Boavizta/environmental-footprint-data/issues/67#issuecomment-1292741358, basically hard_drive values entered manually were misplaced into memory and screen_size fields.

The boavizta-data-fr.csv file just was updated running:

python tools/gen_fr.py -s boavizta-data-us.csv -o boavizta-data-fr.csv
AirLoren commented 1 year ago

Hi @pabluk, Thanks for the contribution but I can't see any change on screen size in your commits. I only see changes on memory/hard_drive

AirLoren commented 1 year ago

Sorry @pabluk I didn't see that some storage data was in screen_size column.

pabluk commented 1 year ago

Sorry @pabluk I didn't see that some storage data was in screen_size column.

No problem @AirLoren, it wasn't easy to spot them in the CSV. Thanks for the review!