Bob74 / bob74_ipl

Fix holes and customize the map
https://forum.fivem.net/t/release-fix-holes-in-the-map/25240
MIT License
249 stars 230 forks source link

Fixed cargoship door and franklin house props #151

Closed NeenGame closed 1 month ago

NeenGame commented 1 month ago

CargoShip

image_2024-08-29_030610910

image_2024-08-28_224319073

Franklin

Screenshot 2024-08-29 025532 Screenshot 2024-08-29 025526

Screenshot 2024-08-29 025937 image_2024-08-29_030146785

TheIndra55 commented 1 month ago

Would you please be able to split the cargo ship fixes and the other changes you did?

On Wed, Aug 28, 2024, 9:44 PM Marian @.***> wrote:

image_2024-08-28_224319073.png (view on web) https://github.com/user-attachments/assets/3759d4a7-d580-43bf-a00e-e0c07fcb7ee0

You can view, comment on, or merge this pull request online at:

https://github.com/Bob74/bob74_ipl/pull/151 Commit Summary

File Changes

(4 files https://github.com/Bob74/bob74_ipl/pull/151/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/Bob74/bob74_ipl/pull/151, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADU4X65WK2LVNNPS63IZXKDZTYSCHAVCNFSM6AAAAABNI64XZOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ4TEOBWGM2DINQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

NeenGame commented 1 month ago

Would you please be able to split the cargo ship fixes and the other changes you did? On Wed, Aug 28, 2024, 9:44 PM Marian @.> wrote: image_2024-08-28_224319073.png (view on web) https://github.com/user-attachments/assets/3759d4a7-d580-43bf-a00e-e0c07fcb7ee0 ------------------------------ You can view, comment on, or merge this pull request online at: #151 Commit Summary - 7d36750 <7d36750> Fixed cargoship door File Changes (4 files https://github.com/Bob74/bob74_ipl/pull/151/files) - M README.md https://github.com/Bob74/bob74_ipl/pull/151/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 (3) - M fxmanifest.lua https://github.com/Bob74/bob74_ipl/pull/151/files#diff-a1b6cdbd198719ffbf8aa8dd148ec4ed4a7255757c67d149690df467d116d072 (2) - A stream/m23_2_cargoship.ymap https://github.com/Bob74/bob74_ipl/pull/151/files#diff-97a2503b52eac23c36639f3aecc4d2ccb4fde6a15aeb09bf576b423a6f7bb3d7 (0) - A stream/m23_2_mp2023_02_dlc_int_5.ytyp https://github.com/Bob74/bob74_ipl/pull/151/files#diff-b6fe2334fa34e14eef9ecaf2dcb2bb68e28c79b24a43b593921192bb91b7a2d1 (0) Patch Links: - https://github.com/Bob74/bob74_ipl/pull/151.patch - https://github.com/Bob74/bob74_ipl/pull/151.diff — Reply to this email directly, view it on GitHub <#151>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADU4X65WK2LVNNPS63IZXKDZTYSCHAVCNFSM6AAAAABNI64XZOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ4TEOBWGM2DINQ . You are receiving this because you are subscribed to this thread.Message ID: @.>

I really don't know how

Bob74 commented 1 month ago

Well it looks like you mostly added your own housing likings but this is meant to be customized by server owners, so I don't think we should add this part. The cargoship door fix is neat though.

Also, are you sure this whitespace is not needed anymore? image

Legacy-TacticalGamingInteractive commented 1 month ago

I like the cargo ship door fix 💯

NeenGame commented 1 month ago

#