feat(table-style): change layout of contributors table

baileythegreen commented 3 years ago

Description

This increases the spacing between individual images/names in the contributor table, and wraps long names. Previously, there was not always sufficient space between individual entries, and long names caused table columns to have different widths.

Created two variables: cell_width and cell_height, whose values are derived from img_width and used to set the style of td. I also added padding to the top of the image objects, to the tune of 10px to ensure there would always be some gap.

Closes: #31 .

How Has This Been Tested

I have used the baileythegreen/add-contributors@patch-1 branch to test this at: https://baileythegreen.github.io/glosario/contributors/ by modifying the contributors.yml file to use my revised version.

Screenshots(optional)

Previous version with uneven spacing and elements too close together:

Version with the changes made in this PR:

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

[x] Code follows the code style of this project.
[x] Changes follow the CONTRIBUTING guidelines.
[x] Update necessary documentation accordingly.
[x] Lint and tests pass locally with the changes.
[x] Check issues and pull requests first. You don't want to duplicate effort.

boring-cyborg[bot] commented 3 years ago

Thanks for your first pull request!

gitmagic-app[bot] commented 3 years ago

@baileythegreen - Your pull request does not follow our contribution guidelines. Please review the following issues and update.

pull request title must use proper <type> or <scope>. pull request title must use imperative form - e.g. Add, Fix etc Branch name must have a proper prefix. <header> of commit message must use proper <type> or <scope>. <header> of commit message needs to be less than 51 characters long Each line in <body> of commit message needs to be less than 73 characters long

If you have any questions, please refer to our Contributing Guidelines or ask us here.

Thanks

mergify[bot] commented 3 years ago

Thanks for opening this pull request! Please check out the Contributing Guidelines.

mergify[bot] commented 3 years ago

@baileythegreen Wrong PR Title: Style(main.py) Please check Contributing Guidelines for more information.

mergify[bot] commented 3 years ago

@baileythegreen Contribution Message Convention Tests failed with GitMagic. Please check details and Contributing Guidelines for more information. If you don't want to correct it yourself, just tell the maintainers. They will do it when merging.

mergify[bot] commented 3 years ago

@baileythegreen Contribution Message Convention Tests failed with GitMagic. Please check details and Contributing Guidelines for more information. If you don't want to correct it yourself, just tell the maintainers. They will do it when merging.

baileythegreen commented 3 years ago

@BobAnkh I thought I'd managed to follow all of the Contributing guidelines here, but gitmagic and Title Validator seem unhappy. I have tried modifying the title, to no avail, and I have no idea what gitmagic is failing on.

BobAnkh commented 3 years ago

@baileythegreen Don't worry, I will handle the style problem.

Also, I think this is a new feature(code style actually means something related to indent, white-space, etc)

boring-cyborg[bot] commented 3 years ago

Awesome work, congrats on your first merged pull request!

github-actions[bot] commented 3 years ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue or pull request.

BobAnkh / add-contributors