fix(main): scopeless commits will be picked up now

BobAnkh / auto-generate-changelog

A Github Action to generate CHANGELOG automatically according to conventional commits. Feel free to contribute!

Apache License 2.0

81 stars 22 forks source link

fix(main): scopeless commits will be picked up now #74

Closed sruehl closed 2 years ago

sruehl commented 2 years ago

Description

commits without scopes are not picked up. This PR solves this.

https://github.com/BobAnkh/auto-generate-changelog/issues/11 https://github.com/BobAnkh/auto-generate-changelog/issues/73

How Has This Been Tested

added a testcase for strip commits with a feat: something commit style. Test successful no regression.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

[x] Code follows the code style of this project.
[x] Changes follow the CONTRIBUTING guidelines.
[x] Update necessary documentation accordingly.
[x] Lint and tests pass locally with the changes.
[x] Check issues and pull requests first. You don't want to duplicate effort.

Other information

boring-cyborg[bot] commented 2 years ago

Thanks for your first pull request!

gitmagic-app[bot] commented 2 years ago

@sruehl - Your pull request does not follow our contribution guidelines. Please review the following issues and update.

pull request title must use proper <type> or <scope>. <header> of commit message must use proper <type> or <scope>.

If you have any questions, please refer to our Contributing Guidelines or ask us here.

Thanks

mergify[bot] commented 2 years ago

Thanks for opening this pull request! Please check out the Contributing Guidelines.

mergify[bot] commented 2 years ago

@sruehl Wrong PR Title: fix: scopeless commits will be picked up now Please check Contributing Guidelines for more information.

mergify[bot] commented 2 years ago

@sruehl Contribution Message Convention Tests failed with GitMagic. Please check details and Contributing Guidelines for more information. If you don't want to correct it yourself, just tell the maintainers. They will do it when merging.

gitmagic-app[bot] commented 2 years ago

@sruehl - Your pull request does not follow our contribution guidelines. Please review the following issues and update.

<header> of commit message must use proper <type> or <scope>.

If you have any questions, please refer to our Contributing Guidelines or ask us here.

Thanks

gitmagic-app[bot] commented 2 years ago

Everything looks good :thumbsup:

sruehl commented 2 years ago

btw: @BobAnkh your gitmagic-app demands the optional scope too...

mergify[bot] commented 2 years ago

Thanks for opening this pull request! Please check out the Contributing Guidelines.

sruehl commented 2 years ago

Github apparently closes the PR when you rename your forks main branch. https://github.com/github/renaming

sruehl commented 2 years ago

superseeded by https://github.com/BobAnkh/auto-generate-changelog/pull/75

github-actions[bot] commented 2 years ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue or pull request.