BobAnkh / auto-generate-changelog

A Github Action to generate CHANGELOG automatically according to conventional commits. Feel free to contribute!
Apache License 2.0
81 stars 22 forks source link

feat(main): add options to configure scope related behaviour #75

Closed sruehl closed 2 years ago

sruehl commented 2 years ago

Description

commits without scopes are not picked up. This PR solves this.

https://github.com/BobAnkh/auto-generate-changelog/issues/11 https://github.com/BobAnkh/auto-generate-changelog/issues/73

How Has This Been Tested

added a testcase for strip commits with a feat: something commit style. Test successful no regression.

Types of changes

Checklist

Other information

gitmagic-app[bot] commented 2 years ago

Everything looks good :thumbsup:

sruehl commented 2 years ago

btw: @BobAnkh your gitmagic-app demands the optional scope too...

BobAnkh commented 2 years ago

btw: @BobAnkh your gitmagic-app demands the optional scope too...

😆 Just forget about the robot

I will take a look at your codes ASAP.

mergify[bot] commented 2 years ago

Thanks for opening this pull request! Please check out the Contributing Guidelines.

gitmagic-app[bot] commented 2 years ago

@sruehl - Your pull request does not follow our contribution guidelines. Please review the following issues and update.

<header> of commit message needs to be less than 51 characters long

If you have any questions, please refer to our Contributing Guidelines or ask us here.

Thanks

mergify[bot] commented 2 years ago

@sruehl Contribution Message Convention Tests failed with GitMagic. Please check details and Contributing Guidelines for more information. If you don't want to correct it yourself, just tell the maintainers. They will do it when merging.

codecov[bot] commented 2 years ago

Codecov Report

Merging #75 (38c7fcd) into master (920f902) will increase coverage by 0.64%. The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   31.15%   31.80%   +0.64%     
==========================================
  Files           2        2              
  Lines         276      283       +7     
==========================================
+ Hits           86       90       +4     
- Misses        190      193       +3     
Impacted Files Coverage Δ
main.py 24.60% <75.00%> (+0.92%) :arrow_up:
tests/test_main.py 90.32% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 920f902...38c7fcd. Read the comment docs.

mergify[bot] commented 2 years ago

@sruehl Markdown Files Check failed with markdownlint. Please check details or Contributing Guidelines for more information.

boring-cyborg[bot] commented 2 years ago

Awesome work, congrats on your first merged pull request!

BobAnkh commented 2 years ago

A new version will be released if everything is fine with the changelog generated by the new action.

BobAnkh commented 2 years ago

Really appreciate your help!

github-actions[bot] commented 2 years ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue or pull request.