BobAnkh / auto-generate-changelog

A Github Action to generate CHANGELOG automatically according to conventional commits. Feel free to contribute!
Apache License 2.0
81 stars 22 forks source link

[bug] regex for optional scope does not include : #76

Closed sruehl closed 2 years ago

sruehl commented 2 years ago

Describe the bug

the regex should only match id(optionalsope): something something.

e.g. for the expression ^feat(?:[(](.+?)[)])? it matches currently:

switching the expression to ^feat(?:[(](.+?)[)])?: fixes this issue.

Care must be taken as this line subject = re.sub(regex + r'\s?:\s?', '', head) appends the colon so this needs to be adjusted too.

To Reproduce

use a commit like fixed something or featuring something great (non conventional commit in a nutshell) will appear under the fixed or feature section.

Expected behavior

only match real conventional commits

gitmagic-app[bot] commented 2 years ago

Everything looks good :thumbsup:

gitmagic-app[bot] commented 2 years ago

Everything looks good :thumbsup:

sruehl commented 2 years ago

ok I might be misled by the tool stripping the commits :D ... so I guess false alarm (changelog is clean). I tripple check again and if this is a issue I will reopen it.

github-actions[bot] commented 2 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue.