Closed sruehl closed 2 years ago
Everything looks good :thumbsup:
Everything looks good :thumbsup:
ok I might be misled by the tool stripping the commits :D ... so I guess false alarm (changelog is clean). I tripple check again and if this is a issue I will reopen it.
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue.
Describe the bug
the regex should only match
id(optionalsope): something something
.e.g. for the expression
^feat(?:[(](.+?)[)])?
it matches currently:feat: new feature
feat(comp): new componentfeature
featulalalala this is a radom commit
switching the expression to
^feat(?:[(](.+?)[)])?:
fixes this issue.Care must be taken as this line
subject = re.sub(regex + r'\s?:\s?', '', head)
appends the colon so this needs to be adjusted too.To Reproduce
use a commit like
fixed something
orfeaturing something great
(non conventional commit in a nutshell) will appear under thefixed
orfeature
section.Expected behavior
only match real conventional commits