jkloetzke
commented
6 days ago These are a lot of recipes. Thanks in advance already for brining them upstream. I guess we'll have to add some automated builds in the future to make sure things don't break. But this is another discussion.
Regarding some documentation about the recipes, their category, coding style and so on it perfectly makes sense to start some documentation. I have to admit this is not in any way settled. We also need some documentation how to use the existing recipes. I'll try to create a skeleton in the next days. I would put this documentation in the basement repository, though. There we already imply a directory layout and the basement-gnu-linux layer is just a natural extension.
Regarding the automated YAML coding style checking it really depends on the behaviour tool. At a first glance this sounds like a good idea. Except for the pre commit hook we should run some Github action on a PR to check for the style. I would be open to give it a try.
mahaase
rhubert
Hi, I have "some" new recipes I'd like to upstream in the next days, weeks, months, ... As we're using
git-scms I need to rework them first to use url-scms, but in addition to that I fear package names / paths do not match your expectations. It would be helpful have some kind of contributor guidelines / "where should I place my recipes" guide to avoid renamings, ...In addition to that I think having some code-style specifications would be also helpful. For our recipes we're using https://pre-commit.com/ with https://github.com/google/yamlfmt which works well. Do you think this is useful / helpful? I can come up with a PR for this.