search

BobBuildTool / bob

Bob build tool - Functional cross platform build-automation tool
https://bobbuildtool.dev/
GNU General Public License v3.0
73 stars 44 forks source link

metaEnvironment does not seem to support var substitution #573

Closed sixtyfourktec closed 1 month ago

sixtyfourktec commented 2 months ago

Something like this is not possible right now:

metaEnvironment:
       PKG_VERSION: "$LINUX_VERSION"

If we have generic recipes which e.g. get the version number to be used passed in, it would be nice if this is also reflected in the PKG_VERSION. I guess this would be the main place someone would like to look at for this kind of information.

rhubert commented 2 months ago

I can't remember why we decided not to substitute this. It's also not mentioned in the PR :thinking: @jkloetzke can you remember?

As I also have this use-case and don't see a good reason against I think this could be supported.

jkloetzke commented 2 months ago

IIRC we thought that it's not necessary because the meta environment should describe static properties of the recipe/package. Apparently this assumption simply does not hold. So I guess we should just add the substitution support and let it behave like privateEnvironment.