search

BobHanson / java2script

Java2Script provides an Eclipse Java to JavaScript transpiler, with a nearly complete implementation of the Java Virtual Machine with AWT and Swing in JavaScript, with simple, automated parallel creation of both class files and js files. To date, over 600 applets have been converted.
https://chemapps.stolaf.edu/swingjs/examples.htm
Other
24 stars 11 forks source link

Use regular __CLASS_NAME__ to getParamCode. #233

Closed warownia1 closed 2 years ago

warownia1 commented 2 years ago

Method names use non-dollar variant of their parameter names in their name even if inner types are used e.g. myMethod$org_example_Outer_Inner. Clazz._getParamCode was using a $-separated type name resulting in invalid method names produced by java.reflect tools.

THIS CHANGE IS UNTESTED Please review and test this change. I'm not sure what other places getParamCode was used at that this change might break.

Fix #232

BobHanson commented 2 years ago

This would revert to prior to commit e5b4842054638376e5cb6324ebe93166fe6181d

// BH 2020.07.27 fix for inner class array names

I will check. Please provide the Java code snippet illustrating the problem.