BobHasNoSoul / jellyfin-featured

add a featured content bar to the top of the jellyfin homepage with very little setup required.. you can also add custom lists for specific seasons etc.
63 stars 5 forks source link

Spotlight showing on favorites tab #8

Closed sureshfizzy closed 1 hour ago

sureshfizzy commented 1 month ago

Hi, first of all thanks for these mods, it looks great!! I am facing a issue on favorites tab, I have configured spotlight using the alternative method (slideshow.html) and now I can see spotlight tab on favorites. Due to this, my favourites list are hidden. Attached the pic below.

Jellyfin version: 10.9.8 OS: Ubuntu 22.04

Screenshot_2024-07-30-23-18-30-47_4b95a63cd60fd3e0f30739d89812bf6c

BobHasNoSoul commented 1 month ago

You're welcome I'm glad you found it useful, that's a new one, I have not encountered a favourites bug that stops it from showing i do know it loads above the favorites items. Can you check your inspect options and look for errors in the log when you reload the page in your browser (chrome or firefox developer console is usually decent at this)

On Tue, 30 Jul 2024, 18:52 Suresh S, @.***> wrote:

Hi, first of all thanks for these mods, it looks great!! I am facing a issue on favorites tab, I have configured spotlight using the alternative method (slideshow.html) and now I can see spotlight tab on favorites. Due to this, my favourites list are hidden. Attached the pic below.

Jellyfin version: 10.9.8 OS: Ubuntu 22.04

Screenshot_2024-07-30-23-18-30-47_4b95a63cd60fd3e0f30739d89812bf6c.jpg (view on web) https://github.com/user-attachments/assets/67fa69bc-8ed5-4a16-a464-834c4fb021bf

— Reply to this email directly, view it on GitHub https://github.com/BobHasNoSoul/jellyfin-featured/issues/8, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFPTXLHYKP4GOU6BH7EQZJDZO7HFVAVCNFSM6AAAAABLW3Q4NCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQZTQMZXGM2DAMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

sureshfizzy commented 1 month ago

When i do inspect, i see few errors..

image image
BobHasNoSoul commented 1 month ago

Okay so the first one is an error because there isn't a logo for an item(s) (this is just saying that logo is missing)

The second is a new one.. can you try the following and tell me the result

Create a new user account (or use any other account) favourite one movie one TV show etc (just to create the list in category's)

Then go to the favorites tab and confirm they load

On Wed, 31 Jul 2024, 12:54 Suresh S, @.***> wrote:

When i do inspect, i see few errors.. image.png (view on web) https://github.com/user-attachments/assets/09582713-41f8-4d5a-b36c-2af4b77c95df image.png (view on web) https://github.com/user-attachments/assets/8da099ac-077a-453c-9316-f782391c143c

— Reply to this email directly, view it on GitHub https://github.com/BobHasNoSoul/jellyfin-featured/issues/8#issuecomment-2260344199, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFPTXLHVTYHHUR6WR5AINPTZPDF57AVCNFSM6AAAAABLW3Q4NCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRQGM2DIMJZHE . You are receiving this because you commented.Message ID: @.***>

MilkFlix commented 1 month ago

It's probably because it's trying to fetch a media number that's greater than the number of items. Try setting the max media variable lower.

On Wed, Jul 31, 2024, 4:55 p.m. BobHasNoSoul @.***> wrote:

Okay so the first one is an error because there isn't a logo for an item(s) (this is just saying that logo is missing)

The second is a new one.. can you try the following and tell me the result

Create a new user account (or use any other account) favourite one movie one TV show etc (just to create the list in category's)

Then go to the favorites tab and confirm they load

On Wed, 31 Jul 2024, 12:54 Suresh S, @.***> wrote:

When i do inspect, i see few errors.. image.png (view on web) < https://github.com/user-attachments/assets/09582713-41f8-4d5a-b36c-2af4b77c95df> image.png (view on web) < https://github.com/user-attachments/assets/8da099ac-077a-453c-9316-f782391c143c>

— Reply to this email directly, view it on GitHub < https://github.com/BobHasNoSoul/jellyfin-featured/issues/8#issuecomment-2260344199>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/AFPTXLHVTYHHUR6WR5AINPTZPDF57AVCNFSM6AAAAABLW3Q4NCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRQGM2DIMJZHE>

. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/BobHasNoSoul/jellyfin-featured/issues/8#issuecomment-2261446247, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDZJ2FJINCVHPQWMCY56GIDZPFFMXAVCNFSM6AAAAABLW3Q4NCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRRGQ2DMMRUG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

sureshfizzy commented 1 month ago

I've created a second user and checked from there after adding favorites, but it gives the same result..

Screenshot 2024-08-01 164745

but i can see them on client apps favorite tab (eg: findroid)

MakD commented 4 weeks ago

+1 can replicate the same

BobHasNoSoul commented 3 weeks ago

Updated install instructions can you try the install method using slideshow.html from the repo and using the updated instructions

sureshfizzy commented 1 hour ago

@BobHasNoSoul thanks for fixing it, sorry was been away with some works so couldn't check this out earlier