BobRak / OpenHAB-Smartthings

53 stars 54 forks source link

Smoke Detector carbonMonoxideDetector device discovered as "unknown" #24

Closed megaoldgeek closed 6 years ago

megaoldgeek commented 6 years ago

Shows up in the inbox, but cant be added as a thing... see screen shot.

carbonmono

When you click add a thing, Paper UI shows pops up a snackbar message - 409 - conflict.

018-01-07 04:52:06.989 [WARN ] [g.discovery.internal.PersistentInbox] - Cannot create thing. No binding found that supports creating a thing of type smartthings:carbonMonoxideDetector.

BobRak commented 6 years ago

I'm pretty sure that is fixed in my code that I am currently testing. I hope to be able to push that up to github in the next few days. There will also be some new instructions about using discovery. In summary make sure to add the "Smartthings hub" first.

megaoldgeek commented 6 years ago

Sweet I look forward to testing it! Yeah I fumbled a bit with getting discovery to show up as an option on PaperUI... I then thoroughly re-read your instructions and found where I needed to add my hub IP and port.

megaoldgeek commented 6 years ago

Will the fix you have fix these too?

image

2018-01-07 18:03:36.165 [WARN ] [g.discovery.internal.PersistentInbox] - Cannot create thing. No binding found that supports creating a thing of type smartthings:relativeHumidityMeasurement.

BobRak commented 6 years ago

I just deployed a new release (including jar file) that corrects a number of issues with device configuration. It also corrects a bug in the messages handling between OpenHAB and the Smartthings hub that cause slow response. This release is much faster. Thanks to @fx for figuring this out.

Hopefully this will fix all of your problems but that is probably being overly optimistic given how many devices you have that I don't and therefore haven't been able to test with. As long as people report issues I will work at fixing them.

Bob

megaoldgeek commented 6 years ago

Thanks Bob. Loaded the new snapshot, same thing. Good news the humidity sensors work and so do the tampers!

2018-01-09 00:52:40.932 [WARN ] [g.discovery.internal.PersistentInbox] - Cannot create thing. No binding found that supports creating a thing of type smartthings:carbonMonoxideDetector. I am going to purge my openhab and try again... I've been mucking too much, might be that.

Nope fresh install, same thing.

megaoldgeek commented 6 years ago

Some additional info... Looks like it did find the mapping somewhat..

image

BobRak commented 6 years ago

I have identified the problem. I'll implement a fix as soon as I can find time.

megaoldgeek commented 6 years ago

Awesome, thanks.

BobRak commented 6 years ago

Don:

I just pushed a new org.openhab.binding.smartthings-2.2.0-SNAPSHOT.jar file to github. It includes the CarbonMonoxideDetector correction. Please let me know if this solves that issue.

Also, I would appreciate it if you would let me know of anything else that doesn't work. Before too long I would like to submit this to OpenHAB for their review. Past experience (I did a cm11a (X-10) binding earlier) taught me that it may take as much as 6 months to go from my pull request to production.

Thanks,

Bob

megaoldgeek commented 6 years ago

Bob,

The new snapshot worked flawlessly for the CarbonMonoxideDetector. I'll start another thread for other observations.

Thanks, -don