After updating, UpgradeMODX fails to enter the admin panel. HTTP error ERROR 500

BobRay / UpgradeMODX

A dashboard widget that detects upgrades and (optionally) installs them from within the MODX Manager

https://bobsguides.com/upgrade-modx-package.html

22 stars 14 forks source link

After updating, UpgradeMODX fails to enter the admin panel. HTTP error ERROR 500 #53

Closed kos0760 closed 5 years ago

kos0760 commented 5 years ago

Updated UpgradeMODX to version 2.0.2-pl. After that, I can't log in to the modx admin panel. HTTP error ERROR 500

In the server error log:

[error] [client ...] client denied by server configuration: /var/www/.../data/www/.../core/docs/changelog.txt
PHP Parse error:  syntax error, unexpected '.', expecting ',' or ';' in /var/www/.../data/www/.../core/components/upgrademodx/processors/ugmprocessor.class.php on line 41

version of php on the server 5.4.45

It turned out that the problem was in the widget.

BobRay commented 5 years ago

I don't know what to make of that error.

This is line 41 of that file:

public $logFilePath = MODX_CORE_PATH . 'cache/logs/upgrademodx.log';

The only thing I can think of is that either MODX_CORE_PATH is empty or contains a syntax error, but since it's running from the Manager, I don't see how either condition would be possible.

gravinos commented 5 years ago

I have the same error after update to latest version 2.0.2-pl

Modx version 2.6.5-pl

Test in PHP Version 5.4.45, 5.6 and 7.1

schermata 2018-11-07 alle 16 20 12

kos0760 commented 5 years ago

Thank! I deleted the UpgradeMODX widget from the main page through the database and the site was working. The fact is that on my other sites I updated UpgradeMODX and there were no problems. Only on one site appeared this error, so I am not critical.

BobRay commented 5 years ago

I think this is the fix for that: https://forums.modx.com/thread/104584/upgrademodx-039-versions-empty--check-github-username-039?page=2#dis-post-562586

I'll be releasing a new version soon. You can also look at the fix here

BobRay commented 5 years ago

Sorry, I think that fix is incorrect. Watch for the new version.

sebastian-marinescu commented 5 years ago

Hi @kos0760 @gravino81, can you check if this is still happening with "2.1.2-pl"?

Plushkin commented 5 years ago

Hi, I have the same error after update on Modx version 2.6.5-pl

Plushkin commented 5 years ago

2.1.2-pl same error (

BobRay commented 5 years ago

I really thought I'd corrected that in this commit.

I haven't been able to duplicate the error on any platform, so I can't troubleshoot it.

sturple commented 5 years ago

Hi @BobRay Don't know if this is the same issue, but here is what i believe might be the cause.

My setup

Modx v 2.6.5
UpgradeMODX plugin v1.5.5

How to reproduce

Upgrade packages
UpgradeMODX v1.5.5 -> v2.1.2

What happened

The admin manager gave a 500 error
fatal error message Call to undefined method UpgradeMODX::versionListExists() in the upgrademodx snippet.
In the snippet on line 127 here is the line of code $versionListExists = $upgrade->versionListExists();
I'm guessing in the core modx they added some functions to the $upgrade class, which are not in earler versions of modx core ie 2.6.5, but is in 2.7.1.

How I fixed.

Found old version of upgrademodx snippet, and replaced.
Remove the version and then Re install upgrademodx 1.5.5
Upgrade modx 2.7.1
Upgrade Packages. (upgrademodx to v2.1.2)

BobRay commented 5 years ago

Is it possible that the error message specified line 106 rather than 126?

This error is usually caused by a problem with the News and/or Security feeds on the dashboard, rather than UGM. There's a discussion of it in the troubleshooting section of the docs.