search

BobRay / UpgradeMODX

A dashboard widget that detects upgrades and (optionally) installs them from within the MODX Manager
https://bobsguides.com/upgrade-modx-package.html
22 stars 14 forks source link

Weird font sizes? #71

Closed SnowCreative closed 3 years ago

SnowCreative commented 3 years ago

I'm wondering why the font size is set in your CSS to increase to 200% when the browser width is less than 1300px. It looks kind of weird, and I don't think this happened in previous versions:

Screen Shot 2021-05-31 at 4 08 13 PM

BobRay commented 3 years ago

I don't think that's changed between versions, but I could be wrong.

CSS based on media queries tends to be a compromise between usability and visual attractiveness. I think the point of this one was to make it easier to use for people with fat fingers and/or poor eyesight. ;)

It's problematic because the titles are so long and the space allocated by the Manager layout is somewhat narrow. I didn't want to waste Manager space by making it full width.

SnowCreative commented 3 years ago

So, maybe trigger the change at a much smaller screen width? 1300 pixels is still desktop size, so I don't think many people will be using their fingers yet!

BobRay commented 3 years ago

"1300 pixels is still desktop size"

Right, but it's also the size of some tablets, including the original iPad, and most tablets in portrait orientation. My desktop is 1920 pixels wide, so I'm somewhat spoiled.

What's your recommendation for the pixel width?

SnowCreative commented 3 years ago

I guess laptop screen sizes have increased. Used to be that 1280 was a standard break point. My monitor is 1920 wide, too, but I don't keep my browsers that wide. And what about on an iPad pro? At 1366 pixels wide, that means the smaller type size will apply. Tablet and laptop sizes have kind of converged. Sure is nice to have CSS-only style sheets, but maybe we need to start querying for the device and load custom media queries if it's actually a mobile device? Not exactly what I want to spend my time doing.

BobRay commented 3 years ago

Me too. ;)