BobRay / UpgradeMODX

A dashboard widget that detects upgrades and (optionally) installs them from within the MODX Manager
https://bobsguides.com/upgrade-modx-package.html
22 stars 14 forks source link

UpgradeModx stuck in old version after upgrade. #73

Open spyavery opened 2 years ago

spyavery commented 2 years ago

After upgrading using upgrademodx, the version is still stuck in the old version. Currently trying to upgrade from 2.8.1-pl to 3.0. I have tried upgrading from 2.8.1 -> 2.8.2 -> 2.8.3 also and the same issue persists.

It runs the updates without any error but the version doesn't change. I have cleared cache, deleted cache files, reinstalled pdotools, and upgrademodx extra, stil stuck.

BobRay commented 2 years ago

Have you tried clearing your browser cache and cookies?

If that doesn't work, you could try removing UGM and installing the previous version, available here (click on the "View Deprecated Releases" button).

spyavery commented 2 years ago

Have you tried clearing your browser cache and cookies?

If that doesn't work, you could try removing UGM and installing the previous version, available here (click on the "View Deprecated Releases" button).

Hello Bob, thanks for the reply, i have tried all these and still same thing. Worse part it doesnt give any errors so i cant debug the problem. INstallation completes but still stuck.

BobRay commented 2 years ago

I haven't been able to replicate this.

What version is shown in the core/docs/version.inc.php file?

What's the version in the settings_version System Setting?

Do you have a ugm.devMode System Setting. Set it to "No" if you find it.

Does Setup run at the end of UGM?

Once it gets going, Setup displays the new version number at the top of the screen. Is it correct?

spyavery commented 2 years ago

Hello Bob,

version inc is still stuck at 2:

$v['version']= '2'; // Current version.
$v['major_version']= '8'; // Current major version.
$v['minor_version']= '1'; // Current minor version.
$v['patch_level']= 'pl'; // Current patch level.

settings version still 2.8.1

no ugm.devmode because i downgraded.

Setup runs but still shows version 2.8.1 at the top.

I will turn on ugm verbose and see if i get any erros.

BobRay commented 2 years ago

It sounds like the files aren't actually being downloaded, though UGM thinks they are for some reason. The download and unzip phases of UGM should take some time. Do they?

Normally, the files get downloaded to the ugmtemp directory under the MODX root directory. The location is controlled by the ugm_temp_dir System Setting. UGM deletes the directory after it finishes. You might try first, looking to see if that directory still exists and what's in it.

Another thing to try is changing the System Setting to another directory. Once you do that, UGM should leave the directory alone after it finishes, so you could check to see what's there, if anything.

TBH, the symptoms seem to point to UGM creating a valid, but empty .zip file. If the download failed, UGM would complain. If the .zip file couldn't be unzipped, it would also complain. I can't imagine how that could happen, though.

I should have asked earlier if there's anything relevant in the MODX error log.

spyavery commented 2 years ago

Hello Bob, after checking seems like the ugmtemp folder is not actually being created. Also the upgrade happens instantly no time is wasted. nothing of note in the error logs but i will take another look today.