BobRay / newspublisher

Revolution version of NewsPublisher snippet
https://bobsguides.com/newspublisher-tutorial.html
20 stars 9 forks source link

elFinder breaks in PHP 8.1 #57

Open matdave opened 2 years ago

matdave commented 2 years ago

The version of elFinder that is being used breaks in PHP 8.1. I was able to resolve this by simply updating the elFinder/php folder to the latest version.

BobRay commented 2 years ago

Thanks for the heads up! Did you update with Composer? If so, could you give me the relevant composer.json stuff. The composer.json file in my elFinder directory has no dependencies at all.

matdave commented 2 years ago

@BobRay I just manually uploaded. We have the same thing on Fred. Not sure why we didn't load elFinder via composer, but I'm sure there was maybe a reason... probably :shrug:

BobRay commented 2 years ago

Thanks. I didn't use Composer either. It's weird that the elFinder composer.json file exists, but doesn't contain a single dependency.

On Tue, Jun 28, 2022 at 1:42 PM Mat Dave Jones @.***> wrote:

@BobRay https://github.com/BobRay I just manually uploaded. We have the same thing on Fred. Not sure why we didn't load elFinder via composer, but I'm sure there was maybe a reason... probably 🤷

— Reply to this email directly, view it on GitHub https://github.com/BobRay/newspublisher/issues/57#issuecomment-1169093263, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACRZIQ2RQP3PTRETCQDR5LVRNBSVANCNFSM5ZYJGU7A . You are receiving this because you were mentioned.Message ID: @.***>

BobRay commented 2 years ago

FYI, make sure your elFinder version is at least 2.1.61 -- I just found out that all previous versions have serious security issues (including 2.1.60).

On Tue, Jun 28, 2022 at 5:40 PM Bob Ray @.***> wrote:

Thanks. I didn't use Composer either. It's weird that the elFinder composer.json file exists, but doesn't contain a single dependency.

On Tue, Jun 28, 2022 at 1:42 PM Mat Dave Jones @.***> wrote:

@BobRay https://github.com/BobRay I just manually uploaded. We have the same thing on Fred. Not sure why we didn't load elFinder via composer, but I'm sure there was maybe a reason... probably 🤷

— Reply to this email directly, view it on GitHub https://github.com/BobRay/newspublisher/issues/57#issuecomment-1169093263, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACRZIQ2RQP3PTRETCQDR5LVRNBSVANCNFSM5ZYJGU7A . You are receiving this because you were mentioned.Message ID: @.***>