I wanted to check out and test this reference implementation today but ran into issues when installing it with CMake. More specifically, I found the following two bugs:
There are typos or copy-paste errors in the target sources for the INSTALL_INTERFACE. The names of the five op_traits_... headers are incorrectly spelled as opt_names... (with an additional t).
I wanted to check out and test this reference implementation today but ran into issues when installing it with CMake. More specifically, I found the following two bugs:
There are typos or copy-paste errors in the target sources for the
INSTALL_INTERFACE
. The names of the fiveop_traits_...
headers are incorrectly spelled asopt_names...
(with an additionalt
).https://github.com/BobSteagall/wg21/blob/b7041892ee380d4a2f3ea3ffb40b1f512131203d/CMakeLists.txt#L74-L78
The
matrix
header is not installed because it doesn't match the pattern"*.hpp"
used in thisinstall()
command:https://github.com/BobSteagall/wg21/blob/b7041892ee380d4a2f3ea3ffb40b1f512131203d/CMakeLists.txt#L106-L114