search

BobaBoard / boba-components

BobaBoard's UI components
https://www.bobaboard.com
MIT License
8 stars 17 forks source link

Let users press modifier keys when clicking links and buttons #123

Closed riazaia closed 1 year ago

riazaia commented 1 year ago

I already can't remember why I did it for the buttons, but I believe it's something to do with wanting it to work for thread views?

netlify[bot] commented 1 year ago

Deploy Preview for bobaboard-ui ready!

Name Link
Latest commit 7804d2919b24fef893c69e9afe8b354726a6224c
Latest deploy log https://app.netlify.com/sites/bobaboard-ui/deploys/64a6b6f290948e00081a0118
Deploy Preview https://deploy-preview-123--bobaboard-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

riazaia commented 1 year ago

Forgot to say, this refers to #71

essential-randomness commented 1 year ago

Actually, I don't know that we need it for buttons at all. We only get buttons if there's no href, and if there's no href then there's no "default click-on-url" behavior. So I'd remove that change, tbh.

riazaia commented 1 year ago

Okay, I was trying to be lazy and resolving the conflict on github but that didnt work heh

riazaia commented 1 year ago

Okay, I was trying to be lazy and resolving the conflict on github but that didnt work heh

and then i misclicked and accidentaly closed the PR fghjk