BobaTalks / pick-a-major

0 stars 4 forks source link

add breadcrumb to majorpage #106

Closed Raymond0T closed 1 year ago

Raymond0T commented 1 year ago

Description

What is the purpose of your change?

What areas of the application does this change impact? (changes API, folder structure, etc)

What features/fixes are deferred/not handled in this PR?

-

Preview/Link:

image https://deploy-preview-106--pick-a-major.netlify.app/majors/education

Checklist

netlify[bot] commented 1 year ago

Deploy Preview for pick-a-major ready!

Name Link
Latest commit 9df62dfe9164077c65187e3bcc97f1022abee04e
Latest deploy log https://app.netlify.com/sites/pick-a-major/deploys/645c5ea94c0dc30008e018b8
Deploy Preview https://deploy-preview-106--pick-a-major.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Raymond0T commented 1 year ago

Breadcrumbs can serve not only as the trail of how users got to their page, but also a means for them to go back up if they chose to the parent pages, we should include links to the earlier pages.

Consider thinking about how this can scale across all pages or can you think of a way we can implement this so we can easily generate breadcrumbs on every page?

Our url path is a little weird because we do not have a dedicated page for major or career. We only have the home and results page as the parent page, so I just routed the links back to previous pages using props. Any thoughts on this?