search

BobbyESP / Jetispot

Unofficial Spotify client for Android built with Jetpack Compose, Material 3 and librespot-java. Fork ahead of Tayson's original repo.
Apache License 2.0
176 stars 8 forks source link

Can't login #18

Closed Doid-Reyewliz closed 8 months ago

Doid-Reyewliz commented 1 year ago

I insert all fields correctly but the app says that I'm not a premium user in Spotify but I have an Individual Premium Plan.

BobbyESP commented 1 year ago

Known issue. I'm trying to rebuild the app but the core things has changed a lot and it's hard to keep good.

wrobm2 commented 1 year ago

is there progress with this or any workaround?

CompeyDev commented 1 year ago

@BobbyESP any progress yet? Problem still seems to occur.

BobbyESP commented 1 year ago

Yeah, and it will stay. The app needs a rework. I think I'm gonna archive the repo because it really needs work

CompeyDev commented 1 year ago

Yeah, and it will stay. The app needs a rework. I think I'm gonna archive the repo because it really needs work

I'd be very much open to at least create a workaround or patch, if you could lmk how to setup the development environment up.

BobbyESP commented 1 year ago

Yeah, and it will stay. The app needs a rework. I think I'm gonna archive the repo because it really needs work

I'd be very much open to at least create a workaround or patch, if you could lmk how to setup the development environment up.

I tried, but the fork of Jetispot uses a private outdated library fork of librespot-java created by iTaysonLab and the app it's currently impossible to build. We already talked about this in my Telegram channel.

CompeyDev commented 1 year ago

Yup, I found the same - currently looking at what could be done.

CompeyDev commented 1 year ago

I took at look at the fork, and it looks like a baseless one. There were no commits made by iTaysonLab, it was simply a fork of librespot-java without any changes made, at a old commit.

I switched the dependency to use the latest official librespot-java implementation. Will update if all goes well.

BobbyESP commented 1 year ago

The solution is to remake the app from the ground and scratch with the original librespot-java lib. It's a lot more profit than trying to fix the current app.

BobbyESP commented 1 year ago

I took at look at the fork, and it looks like a baseless one. There were no commits made by iTaysonLab, it was simply a fork of librespot-java without any changes made, at a old commit.

I switched the dependency to use the latest official librespot-java implementation. Will update if all goes well.

I see. I tried to update the lib also, but the compiler gives 800000000 errors and it brokes all (missing classes and proto files changed, etc...)

CompeyDev commented 1 year ago

I took at look at the fork, and it looks like a baseless one. There were no commits made by iTaysonLab, it was simply a fork of librespot-java without any changes made, at a old commit. I switched the dependency to use the latest official librespot-java implementation. Will update if all goes well.

I see. I tried to update the lib also, but the compiler gives 800000000 errors and it brokes all (missing classes and proto files changed, etc...)

My assumption was incorrect, he did indeed make edits.

https://github.com/iTaysonLab/librespot-java/commits/dev-jsp

CompeyDev commented 1 year ago

Oh and, I'm not a professional JVM dev or anything, so I barely have any clue as to what I'm doing haha... just trying to pick things up as we go.

BobbyESP commented 1 year ago

Hahah okay, don't worry, but yeah, this app is kind of special. I can do my own fork and fix this but I'm focused in Spowlo right now

CompeyDev commented 1 year ago

Hahah okay, don't worry, but yeah, this app is kind of special. I can do my own fork and fix this but I'm focused in Spowlo right now

That'd be great if you could that whenever you're free :)

CompeyDev commented 1 year ago

Could you at least tell me what the last functional version of Jetispot was?

BobbyESP commented 1 year ago

Hahah okay, don't worry, but yeah, this app is kind of special. I can do my own fork and fix this but I'm focused in Spowlo right now

That'd be great if you could that whenever you're free :)

Okayy, will try!

BobbyESP commented 1 year ago

Could you at least tell me what the last functional version of Jetispot was?

The latest published was. Spotify changed its auth flow and all went broken

CompeyDev commented 1 year ago

Could you at least tell me what the last functional version of Jetispot was?

The latest published was. Spotify changed its auth flow and all went broken

Ah, I see. Thought it was an issue with a bug in the library or something at some commit.

neeeerrd commented 8 months ago

Upstream Jetispot just got a fix by updating librespot-java I believe. Could the same thing be done with this fork to make it work?

BobbyESP commented 8 months ago

My build already has it fixed, but I haven't uploaded it, sorry. Maybe I will check later for the build and upload it here, but I'm very busy rn 😩💀

CompeyDev commented 8 months ago

That's awesome! Please consider pushing & creating a release ASAP, would be greatly appreciated :)

BobbyESP commented 8 months ago

Fixed

baraary commented 6 months ago

Sorry but the problem is still there and still can't login. Its either says wrong Usernam or password or 2~3 sec after pressing sign in, app will close itself.

fxzxmicah commented 6 months ago

Yes, I have also been prompted for incorrect username or password, but I am sure they are correct.

fxzxmicah commented 6 months ago

I reset my password first, then ignored its password error prompt, kept pressing the Login button, and finally logged in successfully. I can't believe it.

jacksongoode commented 5 months ago

Doesn't work for me currently.