BobbyWibowo / lolisafe

Blazing fast file uploader and awesome bunker written in node! 🚀
MIT License
317 stars 56 forks source link

Building sqlite3 v5.0.1 now requires Python 2 again #360

Closed BobbyWibowo closed 3 years ago

BobbyWibowo commented 3 years ago

Since commit https://github.com/BobbyWibowo/lolisafe/commit/4991b92ae25e8e5fff61b783dd14be16b992612e, sqlite3 npm package returned to using node-gyp that only worked with Python 2 (previously it only worked with Python 3 instead). This is irrelevant if they already have prebuilt binaries for your machines, but otherwise having Python 2 is a requirement to do an automated local build/compile. You may also have to make sure python is indeed pointing to your Python 2, or otherwise you can set a preferred Python binary by following these instructions: https://github.com/nodejs/node-gyp#configuring-python-dependency.

BobbyWibowo commented 3 years ago

Actually, looking back at the past changes from sqlite3 5.0.0 to 5.0.1, I couldn't find anything that implied node-gyp was changed, and thus would cripple Python 3. Changes to the lockfile on that commit and the one after, didn't seem to include any change to node-gyp either. Yet it was a fact that I couldn't build sqlite3 with Python 3 on my CentOS 7 server. I do not have the time to double-check this for now, so just take it as a reference material, haha