BobbyWibowo / lolisafe

Blazing fast file uploader and awesome bunker written in node! 🚀
MIT License
317 stars 56 forks source link

Problem with the waveform #503

Closed perdedora closed 2 years ago

perdedora commented 2 years ago

I was trying to set up the player for playing flac (error was nginx not serving mimetype), and after some tests I realized the waveform isn't working on firefox 100.0.2 and when it works (on chrome) isn't responsive messing the whole player.

BobbyWibowo commented 2 years ago

That's odd I'm on Firefox 100.0.2 and it plays just fine for me, even with FLAC audio file https://safe.fiery.me/v/rv5ZA.flac

Which OS are you on?


Firefox Desktop on Windows ![image](https://user-images.githubusercontent.com/9364930/170624962-488948c6-dfd9-4a90-8636-57b7077c6b94.png) Last I checked there was no issue on my Linux boot either
Firefox Android ![image](https://i.fiery.me/BnLs.png)
BobbyWibowo commented 2 years ago

and when it works (on chrome) isn't responsive messing the whole player.

I can confirm that the waveform is seemingly not being automatically resized when user resize their browser window, however

Oddly enough, supposedly the CSS method they used should have done so (https://github.com/collab-project/videojs-wavesurfer/issues/132#issuecomment-804154183)

BobbyWibowo commented 2 years ago

For the responsiveness issue, should be fixed with https://github.com/BobbyWibowo/lolisafe/commit/3ec7e6c76c92d08c66babfbf224c421cdb9c7691

perdedora commented 2 years ago

That's odd I'm on Firefox 100.0.2 and it plays just fine for me, even with FLAC audio file https://safe.fiery.me/v/rv5ZA.flac

Which OS are you on?

I'm on debian based distro. The problem was with my firefox profile, a clean one worked.

For the responsiveness issue, should be fixed with 3ec7e6c

thanks, it worked.