BoboTiG / ebook-reader-dict

Finally decent dictionaries based on the Wiktionary for your beloved eBook reader. Daily updates & 14 locales supported so far.
http://www.tiger-222.fr/?d=2020/04/17/22/14/21-un-dictionnaire-alternatif-et-complet-pour-votre-liseuse
MIT License
425 stars 24 forks source link

Support Danish (DA) #1951

Closed jolars closed 7 months ago

jolars commented 10 months ago

Fixes #1948

Here is an attempt to support the Danish wiktionary (https://da.wiktionary.org). It's mostly working okay, but I have struggled to get variant support to work. Here's an example for "hunden", which is an inflection of "hund":

{{-da-}}
{{-noun-|da}}
{{infl|da|substantiv form}}
#Bestemt ental af '''[[hund]]'''.

I'm not sure how to deal with this since there's no template connected to the variant ("hund"). Maybe do some replacement through https://github.com/BoboTiG/ebook-reader-dict/blob/2aedd0a7d422bbac2b1fb327f93a13b754ee797e/wikidict/render.py#L299? Do you have any ideas?

BoboTiG commented 10 months ago

This is great, thanks @jolars! 🍾

First, I did not check the code yet. Second, lets tackle more complex variants later. We still have issues with some other locales because of the exact same lack of templates.

I'll get back to you soon (™️).

BoboTiG commented 7 months ago

Thanks a lot @jolars 🍾

Do you think you could translate https://github.com/BoboTiG/ebook-reader-dict/tree/master/docs/da? For screenshots, you can ismply comment out them, I'll see to take them later if you have interesting words.

BoboTiG commented 7 months ago

@all-contributors please add @jolars for code

allcontributors[bot] commented 7 months ago

@BoboTiG

I've put up a pull request to add @jolars! :tada:

jolars commented 6 months ago

Sure, I can give it a shot, but I'm not a native speaker so it might not be perfect :)

BoboTiG commented 6 months ago

Sure, I can give it a shot, but I'm not a native speaker so it might not be perfect :)

Something not perfect will be way enough. With time, maybe someone native will spot issues and fix them :)