search

BoboTiG / pombo

Theft-recovery tracking opensource software.
131 stars 21 forks source link

Pull req #7

Closed drc26A7 closed 8 years ago

drc26A7 commented 8 years ago

Hello,

I have corrected a few bugs that affected me (on a debian 8.5), here are the modifications.

I modified the install script so that it would work when run from the "gnu-linux/" directory. Itherwise I had (different) missing files errors when it was run from either the root folder or the "gnu-linux/" folder.

I corrected a few bugs in pombo.py, the modifications are simple enough to be understood easily.

Yours respectfully,

Quentin.

BoboTiG commented 8 years ago

Hello Quentin, Thank you very much for your efforts! I will merge you changes quickly, but could you apply few changes before? I will comment concerned lines :)

drc26A7 commented 8 years ago

Hello,

I have done the modifications, you will find them on the branch "pullReq" on my repository.

On 25/08/2016 10:15, Tiger-222 wrote:

Hello Quentin, Thank you very much for your efforts! I will merge you changes quickly, but could you apply few changes before? I will comment concerned lines :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BoboTiG/pombo/pull/7#issuecomment-242312688, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXrvr8gAhuUI03ZfzpMrjSiTvnnAc4oks5qjU8GgaJpZM4JsPfD.

BoboTiG commented 8 years ago

Great! I merged your work into the develop branch. It will close this PR when merging into the master one. Again, thank you :)

BoboTiG commented 8 years ago

Yep, I already fixed with the last commit (https://github.com/BoboTiG/pombo/commit/9339b1822dc1d49f7f01d46fa99db194e7bbeb48). Can you work on the develop branch for future contribution please?

drc26A7 commented 8 years ago

On 02/09/2016 09:29, Tiger-222 wrote:

Yep, I already fixed with the last commit (9339b18 https://github.com/BoboTiG/pombo/commit/9339b1822dc1d49f7f01d46fa99db194e7bbeb48). Can you work on the |develop| branch for future contribution please?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BoboTiG/pombo/pull/7#issuecomment-244303378, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXrvq6KtJWirsUqsGV65eajX6LJ7w8Hks5ql9BKgaJpZM4JsPfD.

OK, no problem.

I am using the "social" aspect of github for the first time, I didn't thought that pushing this commit would notify you about it.

BoboTiG commented 8 years ago

All future commits you will push to thaty brant (pullReq) will notify here. I will close the PR as it will be merged to the master branch later. When you want to add new feature or fix something, create a specific branch ;)