Open dynobo opened 4 years ago
Hello,
Thanks for starting the discussion :) It would be cool to have MSS working on Wayland, I will check that when I can (PRs are still very welcome too :smiley:).
really looking fow wayland support
Hello,
I started looking at wayland support. I have worked on a very basic (incomplete) implementation repository .
However I am getting horrible FPS (~3.5) and it pulls in two external dependencies (python-dbus and pygoobject).
There are two points of interest:
Screenshot
on Service org.freedesktop.portal.Desktop
, with object /org/freedesktop/portal/desktop
, and interface org.freedesktop.portal.Screenshot
.
This will return the path of an object: request_path
2.2 Subscribe to a signal on Service org.freedesktop.portal.Desktop
on the object request_path
and interface org.freedesktop.portal.Request
.
2.3 Run the Main Loop (!!!). After a while we will receive a file path.
2.4 Open the file and create a screenshot object.This project (from what I understand) is supposed to be fast and no dependencies. Further steps to be taken:
Concerns:
The dbus event loop seems to be taking ~75% of the time (the remaining 30% being mainly reading the file from disk to a screenshot object). With this latency is xdg-desktop-portal suitable for the python-mss project?
Should I add/modify the Screenshot
object constructors to load images from a file more efficiently?
I have not been able to run the tests as the pygoobject
dependency is causing issues. I am not that familiar with tox
.
I have not made a pull request as this is very very preliminary.
Apologies if I have skipped a step or not seen another discussion.
I also just realized that I bumped a year old thread, sorry for that.
A bump should be no issue as long as this issue is open and there is demand for wayland (or Xwayland on Gnome 40.0 in my case). I've tried the commits of surajRathi, but unfortunately receive NotImplementedError for _monitors_impl. Mss is a dependency for python-imagesearch, which i originally intended to use. As BoboTiG commented, i'm not sure either how far this issue can be solved, because of the general design of wayland. But solving this on gnome certainly seems easier because of it's gnome-screenshot utility.
I recently ran into a similar issue trying to use mss.grab on Fedora 36 and Ubuntu 22.04 LTS On these two versions of Linux they are defaulted to wayland and after a bit of research I learned that it does not work on wayland yet.
So onto a little extra bump here to anyone that understands the issue at hand perhaps
Just wanted to add a little bit in case anyone wants to try to implement it; it looks like most desktop environments have opted to support xdg-desktop-portal, which exposes a Screencasting API, which provides a Pipewire interface to the screencast: https://docs.flatpak.org/en/latest/portal-api-reference.html#gdbus-org.freedesktop.portal.ScreenCast It looks like there's some talk in python-pillow to use this in case that provides some more useful resources: https://github.com/python-pillow/Pillow/issues/6392
General information:
For GNU/Linux users:
Description of the warning/error
When running
mss
under Wayland, it crashs. As far as I understand from the source code,mss
currently uses xlib for Linux, which seems to (unsurprisingly) not work on Wayland. It would be very cool to have wayland support implemented, as it becomes more and more popular.Full message
Example: Executing the following snippet under X works perfectly, while under Wayland it produces an error.
Snippet:
Error on Wayland:
Other details
A lot of screenshot tools (e.g. shutter) have this issue, because screenshots seem to work completely different in Wayland (to improve security). Applications that do work are e.g.:
A proper way to do screenshots under Wayland is referenced in a flameshot issue and might help solving this in
mss
, too. The main statement from that issue:Upvote & Fund