Windows: fix multi-thread unsafe and update test

BoboTiG / python-mss

An ultra fast cross-platform multiple screenshots module in pure Python using ctypes.

https://pypi.org/project/mss/

MIT License

998 stars 89 forks source link

Windows: fix multi-thread unsafe and update test #159

Closed narumi147 closed 4 years ago

narumi147 commented 4 years ago

Changes proposed in this PR

Fixes #150
replace srcdc with srcdc_dict to maintain srcdc values created by multiple threads
add a threading lock MSS._lock to ensure multi-thread safe

It is very important to keep up to date tests and documentation.

[x] Tests added/updated
[x] Documentation updated

Is your code right?

[ ] PEP8 compliant
[x] flake8 passed

narumi147 commented 4 years ago

Sorry @BoboTiG , I have forgotten to remove the wrong comment Every loop will take about 1 second. in test_windows.py. Please update it later.

If one second per loop, the exception caused by resouces written by multiple threads at same time will occur at a very low possibility. So I removed time.sleep() in the test but forgot to update comment.

BoboTiG commented 4 years ago

OK thanks :)