BoboTiG / python-mss

An ultra fast cross-platform multiple screenshots module in pure Python using ctypes.
https://pypi.org/project/mss/
MIT License
998 stars 88 forks source link

Linux: better handling of the Xrandr extension (fixes #168) #176

Closed BoboTiG closed 4 years ago

BoboTiG commented 4 years ago

Changes proposed in this PR

sourcery-ai[bot] commented 4 years ago

Sourcery Code Quality Report (beta)

✅ Merging this PR will increase code quality in the affected files by 0.01 out of 10.

Before After Change
Quality 8.55 8.55 0.01
Complexity 1.4 1.41 0.01
Method Length 63.17 62.81 -0.36
Lines 715 751 36
Changed files Quality Before Quality After Quality Change
mss/base.py 9.15 9.15 0.0
mss/linux.py 7.57 7.61 0.04 ⬆️
mss/tests/test_gnu_linux.py 8.86 8.91 0.05 ⬆️

Here are some functions in these files that still need a tune-up:

File Function Quality Recommendation
mss/base.py MSSBase.save 5.54 Split out functionality
mss/linux.py MSS._set_cfunctions 5.7 Split out functionality
mss/linux.py MSS.__init__ 6.16 Split out functionality

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it via email or our Gitter!