Closed BoboTiG closed 4 years ago
✅ Merging this PR will increase code quality in the affected files by 0.02 out of 10.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 1.20 | 1.20 | 0.00 |
Method Length | 74.55 | 73.35 | -1.20 🔵 |
Quality | 8.36 | 8.38 | 0.02 🔵 |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 185 | 184 | -1 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
mss/darwin.py | 8.36 | 8.38 | 0.02 🔵 |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Overall | Recommendation |
---|---|---|---|---|---|
mss/darwin.py | MSS._grab_impl | 6 | 190.90 | 5.69 | Split out functionality |
mss/darwin.py | MSS._set_cfunctions | 0 | 208.84 | 6.10 | Split out functionality |
mss/darwin.py | MSS._monitors_impl | 3 | 176.82 | 6.16 | Split out functionality |
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Let us know what you think of it by mentioning @sourcery-ai in a comment.
A disassembling of the code show a reduction of calls:
import mss
import dis
with mss.mss() as sct:
dis.dis(sct._grab_impl)
Changes proposed in this PR
int()
built-in function is no more called.