Closed zorvios closed 1 year ago
❌ Merging this PR will decrease code quality in the affected files by 0.66%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 1.70 ⭐ | 2.11 ⭐ | 0.41 👎 |
Method Length | 75.42 🙂 | 80.89 🙂 | 5.47 👎 |
Working memory | 10.35 😞 | 10.23 😞 | -0.12 👍 |
Quality | 74.81% 🙂 | 74.15% 🙂 | -0.66% 👎 |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 1093 | 1246 | 153 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
mss/base.py | 89.39% ⭐ | 83.98% ⭐ | -5.41% 👎 |
mss/darwin.py | 76.20% ⭐ | 78.36% ⭐ | 2.16% 👍 |
mss/linux.py | 63.18% 🙂 | 62.07% 🙂 | -1.11% 👎 |
mss/windows.py | 65.76% 🙂 | 69.56% 🙂 | 3.80% 👍 |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
mss/base.py | MSSBase.draw | 18 🙂 | 274 ⛔ | 17 ⛔ | 27.76% 😞 | Try splitting into smaller methods. Extract out complex expressions |
mss/linux.py | MSS._set_cfunctions | 2 ⭐ | 253 ⛔ | 33 ⛔ | 37.27% 😞 | Try splitting into smaller methods. Extract out complex expressions |
mss/base.py | MSSBase.save | 14 🙂 | 145 😞 | 13 😞 | 45.03% 😞 | Try splitting into smaller methods. Extract out complex expressions |
mss/darwin.py | MSS._grab_impl | 6 ⭐ | 191 😞 | 15 😞 | 45.30% 😞 | Try splitting into smaller methods. Extract out complex expressions |
mss/darwin.py | MSS._set_cfunctions | 1 ⭐ | 135 😞 | 30 ⛔ | 48.06% 😞 | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Let us know what you think of it by mentioning @sourcery-ai in a comment.
Hello @zorvios,
Sorry for all those code changes since your opened the PR, and a big thank you for your work 💪
I will come back to you later, I need to think about how that new feature could be implemented.
Is this ever going to ship?
Is this ever going to ship?
????
Yay it got approved, now let's merge it and be done with it :)
Approved by someone who never committed to the project, it has no value ;)
Sorry, I may find some time to fully check the patch, thanks for your patience.
Oh well that's a bummer, have fun checking it :)
I presume the status of this PR hasn't changed?
Changes proposed in this PR
It is very important to keep up to date tests and documentation.
Is your code right?
flake8
passed