Closed Tonyl314 closed 2 years ago
Merging this PR leaves code quality unchanged.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 3.42 ⭐ | 3.42 ⭐ | 0.00 |
Method Length | 67.48 🙂 | 67.48 🙂 | 0.00 |
Working memory | 8.66 🙂 | 8.66 🙂 | 0.00 |
Quality | 69.42% 🙂 | 69.42% 🙂 | 0.00% |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 1151 | 1151 | 0 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
mss/base.py | 74.00% 🙂 | 74.00% 🙂 | 0.00% |
mss/darwin.py | 64.92% 🙂 | 64.92% 🙂 | 0.00% |
mss/factory.py | 85.74% ⭐ | 85.74% ⭐ | 0.00% |
mss/linux.py | 67.74% 🙂 | 67.74% 🙂 | 0.00% |
mss/windows.py | 71.24% 🙂 | 71.24% 🙂 | 0.00% |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
mss/base.py | MSSBase.save | 14 🙂 | 144 😞 | 12 😞 | 46.71% 😞 | Try splitting into smaller methods. Extract out complex expressions |
mss/darwin.py | MSS._grab_impl | 6 ⭐ | 185 😞 | 13 😞 | 48.47% 😞 | Try splitting into smaller methods. Extract out complex expressions |
mss/darwin.py | MSS._monitors_impl | 3 ⭐ | 172 😞 | 11 😞 | 55.86% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
mss/windows.py | MSS._grab_impl | 4 ⭐ | 150 😞 | 11 😞 | 57.04% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
mss/linux.py | MSS._monitors_impl | 4 ⭐ | 148 😞 | 10 😞 | 59.15% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
Thanks @Tonyl314 :)
Changes proposed in this PR
It is very important to keep up to date tests and documentation.
Is your code right?
flake8
passed