Open BoboTiG opened 1 year ago
Note: it targets all Python versions (from 3.8 to 3.12 at the moment), and implementations (CPython, and PyPy).
About the failure, it seems that only test_grab_individual_pixels()
has the issue. It just happened again on CPython 3.10 (job)
test_grab_individual_pixels()
was renamed test_get_pixel()
in #252. no more failure is expected given that it no more uses MSS to grad a screenshot.
But I enhances test_grab_part_of_screen()
at the same time to take a lot more region screenshots. If something must fail, it will be there :)
I'll merge #252, it almost never passes on the CI (either we hit the segfault, or the failure). @mgorny how do you feel about that? Do you think we can manage to find a fix a some point? 🤞🏻
Nevermind, I simplified the test to no trigger the issue. But now, the same failure happens with other tests like test_keys_aio()
. There is definitively something wrong with the CI. I can't reproduce locally.
Hmm but test_keys_aio()
doesn't spawn another Xvfb but uses the one spawned by GHA, right? This is weird.
I suppose we could just start using pytest-rerunfailures
to have the tests retry a few times if necessary. That's just a hack, though but it should help distinguish real problems from flakiness. I'll make a PR shortly, I have a high system load right now, so I can reproduce ;-).
Hmm but
test_keys_aio()
doesn't spawn another Xvfb but uses the one spawned by GHA, right? This is weird.
Indeed. I think a test run before might break something. Or xvfb-run may have hard time for whatever reason.
I suppose we could just start using
pytest-rerunfailures
to have the tests retry a few times if necessary. That's just a hack, though but it should help distinguish real problems from flakiness. I'll make a PR shortly, I have a high system load right now, so I can reproduce ;-).
Great add 👍🏻 Thanks !
Such a segfault happens quite often, event after:
247
248
249
On the other hand, #247 did a good job at preventing more segfaults, but we now have more failures like:
Lets see if we can improve the situation.
Upvote & Fund