search

BoboTiG / thermalprinter

Python module to manage the DP-EH600 thermal printer.
https://pypi.org/project/thermalprinter/
MIT License
33 stars 8 forks source link

Add option to specify command timeout (Sourcery refactored) #18

Closed sourcery-ai[bot] closed 2 years ago

sourcery-ai[bot] commented 2 years ago

Pull Request #17 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to the original Pull Request

    Incorporate changes via command line 
    git fetch https://github.com/BoboTiG/thermalprinter pull/17/head
git merge --ff-only FETCH_HEAD
git push

NOTE: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Help us improve this pull request!

sourcery-ai[bot] commented 2 years ago

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.28%.

Quality metrics Before After Change
Complexity 5.02 ⭐ 4.61 ⭐ -0.41 👍
Method Length 50.20 ⭐ 50.46 ⭐ 0.26 👎
Working memory 6.75 🙂 6.77 🙂 0.02 👎
Quality 75.92% ⭐ 76.20% ⭐ 0.28% 👍
Other metrics Before After Change
Lines 681 687 6
Changed files Quality Before Quality After Quality Change
tests/test_methods.py 73.97% 🙂 73.96% 🙂 -0.01% 👎
thermalprinter/init.py 87.84% ⭐ 87.84% ⭐ 0.00%
thermalprinter/thermalprinter.py 75.80% ⭐ 76.09% ⭐ 0.29% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
thermalprinter/thermalprinter.py ThermalPrinter.image 19 😞 196 😞 14 😞 34.92% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
tests/test_methods.py test_signature 0 ⭐ 391 ⛔ 6 ⭐ 60.26% 🙂 Try splitting into smaller methods
thermalprinter/thermalprinter.py ThermalPrinter.__repr__ 8 ⭐ 106 🙂 10 😞 60.34% 🙂 Extract out complex expressions
thermalprinter/thermalprinter.py ThermalPrinter.__init__ 3 ⭐ 136 😞 10 😞 61.47% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!