search

BoboTiG / thermalprinter

Python module to manage the DP-EH600 thermal printer.
https://pypi.org/project/thermalprinter/
MIT License
33 stars 8 forks source link

Add communication error in status function. #5

Closed d21d3q closed 5 years ago

d21d3q commented 5 years ago

having status function that return True in case no response from printer might be misleading. In library it is written that it might be usefull if there is no RX connected. This commit makes it backward compatible, but IMO it should rise error by defualt, and be able to suppress... but if user can suppress error (because RX is not connected) then he don't care about printer status, so maybe it would be better to set all fields to False by default?

BoboTiG commented 5 years ago

Thank you very much @d21d3q! Think to fix the failing test about the method signature you changed ;)

BoboTiG commented 5 years ago

Also add yourself to CONTRIBUTORS :)

BoboTiG commented 5 years ago

Do you want to add yourself to the CONTRIBUTORS file?

d21d3q commented 5 years ago

I think I can live without it ;)

BoboTiG commented 5 years ago

Thanks!

BoboTiG commented 5 years ago

FI I have some ongoing work and will publish a new version on PyPi very soon.

d21d3q commented 5 years ago

Then I am looking forwad for it

śr., 9 sty 2019 o 23:40 Mickaël Schoentgen notifications@github.com napisał(a):

FI I have some ongoing work and will publish a new version on PyPi very soon.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BoboTiG/thermalprinter/pull/5#issuecomment-452895716, or mute the thread https://github.com/notifications/unsubscribe-auth/AAd9XPxN6QIAWNWH6bCPzOXu4zbsTB0Xks5vBm8ogaJpZM4Z3-pE .