BodenmillerGroup / ImcSegmentationPipeline

A pixel classification based multiplexed image segmentation pipeline
https://bodenmillergroup.github.io/ImcSegmentationPipeline/
MIT License
83 stars 35 forks source link

implementation of mcd file checks #67

Closed SchulzDan closed 3 years ago

SchulzDan commented 3 years ago

Hi, recently we have observed a number of corrupted mcd files which sometimes result in no processing errors but the outputted OME tiffs are either corrupt or e.g. one ROI is simply missing. The txt files however are, to my knowledge, always ok. How much would it slow down the processing if checks would be implemented that compare a) number of ROIs in mcd with txt. based ROIs? b) compare dimensions of ROIs in mcd with dimensions in txt? I guess b) I guess b) would be much more intense. What other checks could be implemented? Thanks for thoughts

votti commented 3 years ago

This is definitely a good idea and should be done on the imctools level. Could you open an issue there and ping Anton?

I think the additional computational burden of using the txt files will stilm ne ok - definitely all better than corrupted files.

Cheers!

On Mon, Mar 15, 2021, 09:42 SchulzDan @.***> wrote:

Hi, recently we have observed a number of corrupted mcd files which sometimes result in no processing errors but the outputted OME tiffs are either corrupt or e.g. one ROI is simply missing. The txt files however are, to my knowledge, always ok. How much would it slow down the processing if checks would be implemented that compare a) number of ROIs in mcd with txt. based ROIs? b) compare dimensions of ROIs in mcd with dimensions in txt? I guess b) I guess b) would be much more intense. What other checks could be implemented? Thanks for thoughts

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BodenmillerGroup/ImcSegmentationPipeline/issues/67, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4R2KHKZXJWNUA4ZPTE5J3TDXB7ZANCNFSM4ZGDCFFQ .

plankter commented 3 years ago

Already working on a fix!