search

BodenmillerGroup / cytomapper

R package for visualization of highly multiplexed imaging data
https://bodenmillergroup.github.io/cytomapper/
31 stars 9 forks source link

Adapt comp image tests #84

Closed nilseling closed 11 months ago

nilseling commented 11 months ago

I noticed that I never managed to induce spillover in images in a correct way for the unit tests. This is now more elegant and checks the spillover correction correctly.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e63cbf9) 87.31% compared to head (832e8f1) 87.31%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #84 +/- ## ======================================= Coverage 87.31% 87.31% ======================================= Files 18 18 Lines 2751 2751 ======================================= Hits 2402 2402 Misses 349 349 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lassedochreden commented 11 months ago

Hi @nilseling, as you can see R CMD Check is failing due to Cache PhantomJS (Error: Input required and not supplied: path). Furthermore, there are two deprecation warnings from set-output and node12.

Can you comment on that and potentially fix it?

Thanks in advance for clarifying!

nilseling commented 11 months ago

So the build issue on devel is due to a bunch of packages not being available at the moment. I'm not fully sure why this is but I think we can ignore this for now.