search

BodenmillerGroup / imcRtools

An R package for handling and analysing imaging mass cytometry data
https://bodenmillergroup.github.io/imcRtools/
22 stars 10 forks source link

Community detection function #87

Closed lassedochreden closed 2 years ago

lassedochreden commented 2 years ago

Hi @nilseling,

here is the first version of the detectCommunity function.

Happy to discuss!

codecov-commenter commented 2 years ago

Codecov Report

Base: 99.71% // Head: 99.66% // Decreases project coverage by -0.04% :warning:

Coverage data is based on head (546b49d) compared to base (4578c66). Patch coverage: 97.87% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #87 +/- ## ========================================== - Coverage 99.71% 99.66% -0.05% ========================================== Files 22 23 +1 Lines 1733 1780 +47 ========================================== + Hits 1728 1774 +46 - Misses 5 6 +1 ``` | [Impacted Files](https://codecov.io/gh/BodenmillerGroup/imcRtools/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BodenmillerGroup) | Coverage Δ | | |---|---|---| | [R/minDistToCells.R](https://codecov.io/gh/BodenmillerGroup/imcRtools/pull/87/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BodenmillerGroup#diff-Ui9taW5EaXN0VG9DZWxscy5S) | `100.00% <ø> (ø)` | | | [R/detectCommunity.R](https://codecov.io/gh/BodenmillerGroup/imcRtools/pull/87/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BodenmillerGroup#diff-Ui9kZXRlY3RDb21tdW5pdHkuUg==) | `95.00% <95.00%> (ø)` | | | [R/utils.R](https://codecov.io/gh/BodenmillerGroup/imcRtools/pull/87/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BodenmillerGroup#diff-Ui91dGlscy5S) | `99.67% <100.00%> (+<0.01%)` | :arrow_up: | | [R/validityChecks.R](https://codecov.io/gh/BodenmillerGroup/imcRtools/pull/87/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BodenmillerGroup#diff-Ui92YWxpZGl0eUNoZWNrcy5S) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BodenmillerGroup). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BodenmillerGroup)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

nilseling commented 2 years ago

Great work! Nearly ready to merge. Do you mind bumping the version, adjusting NEWS and adding the function to the vignette?