search

BodenmillerGroup / imcRtools

An R package for handling and analysing imaging mass cytometry data
https://bodenmillergroup.github.io/imcRtools/
20 stars 10 forks source link

Fixed bug with .calc_p_vals util function #97

Closed ajxa closed 1 year ago

ajxa commented 1 year ago

The function was referencing the wrong data.table when filtering out missing count values, resulting in a data.table error:

image
nilseling commented 1 year ago

Hmm, which version of imcRtools are you using? dat_baseline and dat_stat should have the same number of rows

ajxa commented 1 year ago

Hi Nils, I'm using version 1.3.10

nilseling commented 1 year ago

That's already quite an old version. Could you please update to the newest devel version 1.5.2 and see if the error persists?

nilseling commented 1 year ago

Could you potentially also share the data that you are working with for me to have a look?

nilseling commented 1 year ago

Hi @ajxa

are there any updates on this? If the issue still occurs in the newest version of the package, could you please send me the data at nils.eling@uzh.ch?

nilseling commented 1 year ago

Hi @ajxa

I have now release a new version of imcRtools (1.5.5). Could you please install it via remotes::install_github("BodenmillerGroup/imcRtools") and let me know if the issue is fixed?

nilseling commented 1 year ago

I'm now closing this due to inactivity