Unifying how panel column datatypes are handeled & adding cellpose 2.0 support

BodenmillerGroup / steinbock

A toolkit for processing multiplexed tissue images

https://bodenmillergroup.github.io/steinbock

MIT License

49 stars 14 forks source link

Unifying how panel column datatypes are handeled & adding cellpose 2.0 support #175

Closed Milad4849 closed 1 year ago

Milad4849 commented 1 year ago

Changed the pandas series dtype assignment of columns in imc._clean_panel to float.

jwindhager commented 1 year ago

Hi Milad! Do you still need a review here? Also, this PR now seems to be for cellpose?

Milad4849 commented 1 year ago

Hi Jonas, yes it would be great if you could review the cellpose2.0 part. The initial PR was a very minor issue, I added the cellpose commit on top. Would you normally do a separate PR?

jwindhager commented 1 year ago

Ok, will review asap!

Regarding the PR: Yes, on the steinbock repository I'd usually develop in feature branches and merge them into the develop branch using separate PRs (gitflow model without release branches, see here). This makes it easier to track changes and do reviews and such. But for now, lets just rename this PR :-)