search

BodenmillerGroup / steinbock

A toolkit for processing multiplexed tissue images
https://bodenmillergroup.github.io/steinbock
MIT License
49 stars 14 forks source link

Enhance errmsg for misssing roi #212

Closed Milad4849 closed 1 year ago

Milad4849 commented 1 year ago

Testing solution for the centrosome issue, corrections in cellprofiler not propagated to the package yet.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (418a634) 30.65% compared to head (532e66b) 30.65%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #212 +/- ## ======================================= Coverage 30.65% 30.65% ======================================= Files 66 66 Lines 2512 2512 ======================================= Hits 770 770 Misses 1742 1742 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jwindhager commented 1 year ago

I'm indifferent about this change, but would be cautious of releasing CellProfiler development versions as a stable release to the public. Up to you :)

Milad4849 commented 1 year ago

@jwindhager, agreed, I am not intending to release a version with this change. This is just to make the merges to the main pass so I can work on the feature branches. Once everything is ready for the release, we will reevaluate the situation, the issue with cellprofiler would hopefully be fixed by then.