(WIP) Improved Cyclic group type

Bodigrim / arithmoi

Number theory: primes, arithmetic functions, modular computations, special sequences

http://hackage.haskell.org/package/arithmoi

MIT License

147 stars 40 forks source link

(WIP) Improved Cyclic group type #158

Closed b-mehta closed 5 years ago

b-mehta commented 5 years ago

A very rough draft for a possible fix for #154. isPrimitiveRoot'2 is essentially just a smart constructor for PrimitiveRoot now, while isPrimitiveRoot2 has virtually the same functionality as before. In addition, isPrimitiveRoot'2 avoids the potentially expensive factorisation of modulus.

Possibly fixes #154.

Bodigrim commented 5 years ago

Closed in favor of #169. Thanks for your efforts any way!