search

Bodigrim / arithmoi

Number theory: primes, arithmetic functions, modular computations, special sequences
http://hackage.haskell.org/package/arithmoi
MIT License
147 stars 40 forks source link

Move roots of unity to utils and ignore vim .swp files #186

Closed hgsipiere closed 4 years ago

hgsipiere commented 4 years ago

This moves roots of unity to the utilities section.

It leaves it as an exposed module so that the tests can build.

hgsipiere commented 4 years ago

Thanks for your feed back!

I left out the copyright and maintainer, because I wasn't sure what to write.

This is small and not related to this pull request but DirichletCharactersTests.hs refers to Module: Math.NumberTheory.Moduli.DiscreteLogarithm rather than Math.NumberTheory.DirichletCharactersTests.

Bodigrim commented 4 years ago

I left out the copyright and maintainer, because I wasn't sure what to write.

Please retain the original copyright, when moving code around. There may be options with regards to Maintainer, if the original maintainer become unreachable, but since this is not the case, I would probably retain it as well.

This is small and not related to this pull request but DirichletCharactersTests.hs refers to...

Nice catch. It will be very much appreciated, if you fix this as well.

b-mehta commented 4 years ago

This is small and not related to this pull request but DirichletCharactersTests.hs refers to...

Nice catch. It will be very much appreciated, if you fix this as well.

Seconded, thanks for this catch and fix!

Bodigrim commented 4 years ago

Thanks, @hgsipiere!