search

Bodigrim / tasty-bench

Featherlight benchmark framework, drop-in replacement for criterion and gauge.
https://hackage.haskell.org/package/tasty-bench
MIT License
80 stars 11 forks source link

Fix #31, fix #28: correct verbalization of slowdown/speed up #32

Closed andreasabel closed 2 years ago

andreasabel commented 2 years ago

Fixes

Follows suggestion raised towards

New output (example):

  insert
    Set Bool: OK (1.80s)
      845  ns ±  63 ns, unchanged against baseline
    BoolSet:  OK (2.34s)
      138  ns ± 7.2 ns, faster than baseline by factor 6.13
Bodigrim commented 2 years ago

Superseded by fce531307fd58f2b94f81ce4c8445c693fae070b

andreasabel commented 2 years ago

LGTM, except for missing acknowledgement in commit, e.g. "jww Andreas Abel" or "with contributions by ..." etc. Citations, acknowledgements and the like are the currency in science and volunteer work. Next time...

Bodigrim commented 2 years ago

@andreasabel sorry, I appreciate our discussion in #28 a lot and it is cited in the commit message. In terms of actual implementation fce531307fd58f2b94f81ce4c8445c693fae070b does not bear much resemblance to 003ad47 or 51ca6ce, and I did not read them beforehand.

andreasabel commented 2 years ago

... and I did not read them beforehand.

That doesn't make it better, haha! Anyway, not a big thing...