cgandrewdev commented 2 years ago

Hi I have been successfully using the TFT_eSPI library on an ESP32 WROOM dev kit in conjunction with an ST7789 based SPI TFT LCD 240x240 module in the Arduino UI. The library works really well, thank you.

I have switched to a newer dev kit, the ESP32-C3-WROOM-02 dev kit which uses the newer C3 module. But I have not been able to compile the example project, for example the Read_User_Setup project. It compiles and runs fine when I set the Board to ESP32 Dev Module but as soon as I change the board to ESP32C3 Dev Module and change the port and recompile, I get pages full of errors:

In file included from C:\Users\P50\Documents\Arduino\libraries\TFT_eSPI\TFT_eSPI.cpp:20:
C:\Users\P50\Documents\Arduino\libraries\TFT_eSPI\Processors/TFT_eSPI_ESP32.c:23:34: error: 'HSPI_HOST' was not declared in this scope
     spi_host_device_t spi_host = HSPI_HOST;
                                  ^~~~~~~~~
C:\Users\P50\Documents\Arduino\libraries\TFT_eSPI\Processors/TFT_eSPI_ESP32.c:23:34: note: suggested alternative: 'SPI3_HOST'
     spi_host_device_t spi_host = HSPI_HOST;
                                  ^~~~~~~~~
                                  SPI3_HOST
In file included from C:\Users\P50\Documents\Arduino\libraries\TFT_eSPI\Processors/TFT_eSPI_ESP32.h:12,
                 from C:\Users\P50\Documents\Arduino\libraries\TFT_eSPI\TFT_eSPI.h:65,
                 from C:\Users\P50\Documents\Arduino\libraries\TFT_eSPI\TFT_eSPI.cpp:17:
C:\Users\P50\AppData\Local\Arduino15\packages\esp32\hardware\esp32\2.0.1/tools/sdk/esp32c3/include/soc/esp32c3/include/soc/spi_reg.h:23:34: error: 'REG_SPI_BASE' was not declared in this scope
 #define SPI_CMD_REG(i)          (REG_SPI_BASE(i) + 0x0)
                                  ^~~~~~~~~~~~
C:\Users\P50\Documents\Arduino\libraries\TFT_eSPI\Processors/TFT_eSPI_ESP32.c:31:60: note: in expansion of macro 'SPI_CMD_REG'
   volatile uint32_t* _spi_cmd       = (volatile uint32_t*)(SPI_CMD_REG(SPI_PORT));
                                                            ^~~~~~~~~~~
C:\Users\P50\AppData\Local\Arduino15\packages\esp32\hardware\esp32\2.0.1/tools/sdk/esp32c3/include/soc/esp32c3/include/soc/spi_reg.h:23:34: note: suggested alternative: 'REG_I2S_BASE'
 #define SPI_CMD_REG(i)          (REG_SPI_BASE(i) + 0x0)
                                  ^~~~~~~~~~~~
C:\Users\P50\Documents\Arduino\libraries\TFT_eSPI\Processors/TFT_eSPI_ESP32.c:31:60: note: in expansion of macro 'SPI_CMD_REG'
   volatile uint32_t* _spi_cmd       = (volatile uint32_t*)(SPI_CMD_REG(SPI_PORT));

... and so on, I would have attached the full output as a file but I might not be able to add files.

I am not sure where to start, the errors seem to be SPI related. I have been looking at the specifications for the C3 module and found that it has three SPI ports SPI0, SPI1, and SPI2, only SPI2 is configurable as general purpose SPI. I dont really know what I should be doing to solve this.

If anyone has any advice it would be much appreciated! Thanks

Bodmer commented 2 years ago

The new ESP32-C3 is not currently supported. Today I received an ESP32-S2 board so will be working on adapting the library for that processor, maybe the C3 will then work too.

As you note the issue seems to be SPI port references.

cgandrewdev commented 2 years ago

Thanks very much! I'll be happy to do testing when ready.

Bodmer commented 2 years ago

The library has been updated for the ESP32 S2 processor variant, the changes may also work with the C3 but this is untested and I do not have a C3 board.

BeijingUncle commented 2 years ago

There is a post from Twitter maybe useful: https://twitter.com/martinfasani/status/1386019656016728068?s=20

cgandrewdev commented 2 years ago

Thanks for doing the work on the S2.

I have finally been able to get some time to look at this. I noted that ESP32 Arduino board package 2.0.0 is required per the notes, so I reinstalled with GIT etc. per the instructions here: https://docs.espressif.com/projects/arduino-esp32/en/latest/installing.html

I have Arduino 1.8.16,

The first test, with no dev module plugged in, was to set the target board to ESP32S2 Dev Module and just do a compile, and that worked just fine.

Then I switched to ESP32C3 Dev Module and tried to recompile but I get a similar list of errors as before. This is without any dev module plugged in at all, just compiling for the C3 dev module as the target. You mentioned that you didnt have a C3 dev module but errors I am getting exist without even a dev module plugged in, just by changing to the C3 module as target.

I have attached the error list if that helps any.

If I selected S2 Dev Module and compiled and tried to upload to the C3 module anyway it wont because it knows I have a C3 Module. I am not sure what else I can do to from here. Thoughts?

TFT_eSPI errors.txt

freemanzwin commented 2 years ago

arduino esp32c3 spi is not implemented yet.

esp32s2 spi_reg.h

include "soc.h"

#define REG_SPI_BASE(i) (DR_REG_SPI2_BASE + (((i)>3) ? (((i-2) 0x1000) + 0x10000) : ((i - 2) 0x1000 )))

define SPI_CMD_REG(i) (REG_SPI_BASE(i) + 0x000)

===================================================================

esp32c3 spi_reg.h

include "soc.h"

define SPI_CMD_REG(i) (REG_SPI_BASE(i) + 0x0)

Bodmer commented 2 years ago

The compile problem is caused by bugs and inconsistencies in the IDF for the ESP32C3.

I have added some patches to the latest Github master.

The examples compile OK now but I have not tested the library on the ESP32C3 as I do not have one!

GYSS1204 commented 2 years ago

The compile problem is caused by bugs and inconsistencies in the IDF for the ESP32C3.

I have added some patches to the latest Github master.

The examples compile OK now but I have not tested the library on the ESP32C3 as I do not have one!

Hello, I use your latest library to run on ESP32C3 and drive the ST7789 display screen, but it does not work properly. I use oscilloscope to measure the pin and find no SPI signal output.

Bodmer commented 2 years ago

Thanks for your information. I think we can say the C3 is currently unsupported. I may get a C3 at some point to figure out what is happening.