Bodom78 / kohana-imagefly

A Kohana module to quickly create resized / cropped images directly through url parameters.
MIT License
55 stars 24 forks source link

Expand the API #8

Closed doktorbro closed 10 years ago

doktorbro commented 10 years ago

I’m searching for a solid replacement for Timthumb resize library. I include it in my framework for responsive images Imadaem.

After install Kohana and Imagefly I must say, this solution looks the most promising to me. But I need far more settings and documentation to replace Timthumb. Now I have two options:

  1. Work on your module and Kohana’s Image module. This would be great because:
    • I want to give love upstream;
    • I’m not a Kohana expert;
    • My English is not good enough for a nice documentation.
  2. Fork your module and expand it to do all the things my framework must do.

The first option means an amount of work for the current maintainers too. My questions are:

Bodom78 commented 10 years ago

Are you planning to keep it tied to Kohana or decouple and make it a standalone class to include in Imadaem?

I would prefer to keep the ImageFly API backwards compatible for the time being as It's a module I use for work.

doktorbro commented 10 years ago

I’m planning to include the whole package Kohana+Imagefly to Imadaem as a subdirectory. Everytime Kohana or Imagefly gets updated, I would update Imadaem too.

I’ve analyzed your API and I don’t see any reason for me to break it. You use only 4 letters (w, h, c, q) as URL parameters so we can add 24 new one-letter-options without break anything. This is more than enough.

Bodom78 commented 10 years ago

OK, from the sounds of it I think it's better to fork and modify ImageFly as required by your project.

I would prefer to keep this version as lightweight as possible.

Also be cautious when updating Kohana, many times new versions have breaking changes. Kohana does not generally pollute the code with backwards compatible fixes.

Just curious what else from Kohana you will be using for the framework? is it just for the image manipulation or will there be more?

doktorbro commented 10 years ago

Thanks for the advice, I will watch Kohana’s changes.

I need the routing, the input validation, the image manipulation and the garbage collector to delete outdated files. I expect Kohana can do all these things. Your Imagefly is a great starting point for me, at least I think I understand how to change it for my needs.

There is a mighty image manipulation library Imagine, but I have no idea how to build a full resize service around it inside another framework like Silex. My PHP skills are limited.